Update Visual Basic Project Template (CLI) for 5.0 Preview 8 #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## release/5.0-preview8 #3718 +/- ##
===============================================================
- Coverage 67.08048% 35.44760% -31.63288%
===============================================================
Files 1360 904 -456
Lines 504418 251419 -252999
Branches 40855 36679 -4176
===============================================================
- Hits 338366 89122 -249244
+ Misses 160484 157449 -3035
+ Partials 5568 4848 -720
Flags with carried forward coverage won't be shown. Click here to find out more. |
Shyam-Gupta
reviewed
Aug 10, 2020
...ProjectTemplates/content/WinFormsApplication-CSharp/Company.WinFormsApplication1.csproj.user
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## release/5.0-preview8 #3718 +/- ##
===============================================================
- Coverage 67.08048% 35.46033% -31.62015%
===============================================================
Files 1360 904 -456
Lines 504418 251419 -252999
Branches 40855 36679 -4176
===============================================================
- Hits 338366 89154 -249212
+ Misses 160484 157418 -3066
+ Partials 5568 4847 -721
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Basic will be having a new WinForms project template which works based on the VB Application Framework for Visual Studio 16.9, while the template for CLI should be in the same style as the CS template for Window Forms.
The new VS template for VB WinForms/Application Framework relies on a code generation tool which is only available in VS, so having this template for the CLI version of VB would not work.
The current VB WinForms CLI (
dotnet new winforms --language vb) template however does only invoke the Form it created as a start object. It does not setup other necessary settings, like enabling Visual Styles and setting the correct HighDpiMode, but it should.This PR corrects this.
Microsoft Reviewers: Open in CodeFlow