False Positive Warning for IDE0079 Remove Unneccessary Suppression

[vsfeedback]

This issue has been moved from a ticket on Developer Community.

---

[severity:I'm somewhat annoyed. A fix would be nice] [regression] [worked-in:16.7]
I use the SuppressMessageAttribute to suppress certain Resharper warnings. Visual Studio 2019 16.8.0 preview 2 is incorrectly suggesting that these attributes can be removed because they are not used. In fact, they are being used by Resharper.

[SuppressMessage("ReSharper", "UnusedMember.Global", Justification = "For future use.")]

Would it be possible to check the category and not step on Resharper's SuppressMessage attributes?

---

Original Comments

Feedback Bot on 8/30/2020, 08:05 PM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

---

Original Solutions

(no solutions)

[mavasani]

This is by design, and the analyzer has a configurable option to skip specific diagnostic IDs from analysis. You can specify the following in your .editorconfig file:

roslyn/src/VisualStudio/Core/Test/Options/CSharpEditorConfigGeneratorTests.vb

Line 87 in 163404b

dotnet_remove_unnecessary_suppression_exclusions = none

[*.cs]

dotnet_remove_unnecessary_suppression_exclusions = ID1, ID2

Basically, your options are:

1. Turn off IDE0079 for the entire project
2. Exclude specific diagnostic IDs from IDE0079 analysis as above.

[mavasani]

Would it be possible to check the category and not step on Resharper's SuppressMessage attributes?

Not really - suppress message attributes are meant for suppressing analyzer diagnostics. Any third party component that uses the same suppression mechanisms for suppressing their own custom reported issues is relying on an unsupported suppression mechanism. Adding such a custom exclusion for a specific category used by a particular third party extension is not scalable, as there could be numerous different extensions using their own category that would then request the same.

[mavasani]

Tag @sharwell to bring this up for IDE design meeting review, I have marked this tentatively as by design.

[JoeRobich]

During this weeks design review it was decided to move forward on a proposal to implement category exclusion for these diagnostics in a manner akin to the dotnet_remove_unnecessary_suppression_exclusions setting.

[mavasani]

After #47819 is merged, you should be able to exclude entire category by setting the below editorconfig option:

[*.cs]
dotnet_remove_unnecessary_suppression_exclusions = category: ReSharper

[drvic10k]

I think this not happening only for resharper's rules

[SuppressMessage("Microsoft.Maintainability", "CA1506", Justification = "By Design")] is marked as unneessary but when removed, build detects these errors

[sharwell]

@drvic10k Can you file a new issue for that? It sounds like an unrelated issue.

[drvic10k]

@drvic10k Can you file a new issue for that? It sounds like an unrelated issue.

ok, created one here: #51884