Signature help should use SymbolDisplayMiscellaneousOptions.AllowDefaultLiteral

[Youssef1313]

It's less noisy if IntelliSense just shows default instead of default(CancellationToken).

[sharwell]

This was claimed to be fixed by #33056 for the 16.1 release.

[jinujoseph]

@Youssef1313 will you be able to share specific steps to reproduce this ?

[Youssef1313]

@jinujoseph I think any call to GetSyntaxRootAsync for example should reproduce this (or any method taking an optional CancellationToken).

[Youssef1313]

using System;
using System.Threading;

namespace ConsoleApp19
{
    class Program
    {
        static void SomeMethod(CancellationToken token = default) => throw new NotImplementedException();

        static void Main(string[] args)
        {
            SomeMethod /* Write a parentheses after "SomeMethod" and see the result. */
        }
    }
}

@sharwell, Note the difference in behavior between hovering on the method and the completion for the parameter. The PR you referred to may have only fixed the hovering. Hence, this might not be a regression if the completion for parameter wasn't fixed in the first place. But I'm not 100% sure. Just wanted to note this.

[sharwell]

Thanks for the update. It appears that Quick Info renders symbols with SymbolDisplayMiscellaneousOptions.AllowDefaultLiteral, but Signature Help does not. We would certainly accept a pull request to update the latter to start using this flag as well.