Signature help should use SymbolDisplayMiscellaneousOptions.AllowDefaultLiteral #47552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinujoseph
added
Area-IDE
Community
src/Features/CSharp/Portable/SignatureHelp/AbstractOrdinaryMethodSignatureHelpProvider.cs
Outdated
Show resolved
Hide resolved
Youssef1313
force-pushed
the
patch-7
branch
from
8a7e5ff to
19b5a24
Compare
|
The test passes locally now. This is ready for review. |
Youssef1313
requested review from
CyrusNajmabadi
and removed request for
a team
src/Features/CSharp/Portable/SignatureHelp/AbstractCSharpSignatureHelpProvider.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/SignatureHelp/InvocationExpressionSignatureHelpProviderTests.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Sep 11, 2020
Youssef1313
commented
Sep 11, 2020
src/Features/CSharp/Portable/SignatureHelp/AbstractCSharpSignatureHelpProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Sep 11, 2020
| @@ -53,7 +56,7 @@ protected static SymbolDisplayPart NewLine() | |||
| parameter.Name, | |||
| parameter.IsOptional, | |||
| parameter.GetDocumentationPartsFactory(semanticModel, position, formatter), | |||
| parameter.ToMinimalDisplayParts(semanticModel, position)); | |||
| parameter.ToMinimalDisplayParts(semanticModel, position, s_allowDefaultLiteralFormat)); | |||
There was a problem hiding this comment.
Does this need to take into account language version, so we don't show default literals to people on C# <7.1? Or do we not worry about that sort of thing? Or does ToMinimalDisplayParts take care of that?
There was a problem hiding this comment.
@davidwengier I don't know if ToMinimalDisplayParts accounts for language version or not.
Probably @sharwell or @CyrusNajmabadi know?
There was a problem hiding this comment.
It doesn't need to account for lang version. How we present info is different from what suggestions we offer, or what code we generate :)
ghost
added this to the 
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47364