CodeLens doesn't work on records

[PathogenDavid]

Version Used:

Visual Studio 16.8.0 Preview 2.1
.NET SDK 5.0.100-preview.8.20417.9
Compiler version: '3.8.0-2.20418.7 (0276b9b)'. Language version: 9.0.

Steps to Reproduce:

Enter the following code:

public class Person
{
    public string Name { get; init; }
}

public record PersonRecord
{
    public string Name { get; init; }
}

public static class Factory
{
    public static Person MakePerson(string name)
        => new() { Name = name };

    public static PersonRecord MakeRecord(string name)
        => new() { Name = name };
}

Expected Behavior:

Code Lens shows number of references above PersonRecord and PersonRecord.Name.

Actual Behavior:

Code Lens is missing for record type and its members:

[CyrusNajmabadi]

@jcouv Not critical. @jinujoseph who owns codelens now?

[sharwell]

There are two components to CodeLens: a tagger implemented in devdiv (internal) code, and a references provider implemented here in dotnet/roslyn. Both will need to be updated to report tags and information for the new syntax.

[huoyaoyuan]

What do you plan for codelens on properties that's only declared in primary constructor? Are they not being able to work with?

[CyrusNajmabadi]

VS PR for this here: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/279270

[sharwell]

🔗 Also reported as AB#1245289

[thomaslevesque]

In fact, there are a number of things that don't work for records.

• CodeLens (this issue)
• Go to all / Go to type (see this feedback item)
• In the solution explorer, when you expand a C# file containing a record type, it appears as a method
• Refactorings don't work (e.g. move to namespace (MoveToNamespace doesn't work for records #48315))

[CyrusNajmabadi]

@thomaslevesque what version of vs are you using?

[thomaslevesque]

16.8.1

[thomaslevesque]

In the solution explorer, when you expand a C# file containing a record type, it appears as a method

Sorry, actually I saw that in the screenshot in the feedback item I mentioned. I'm not seeing this on my machine, instead I can't expand the file in the solution explorer if the record is the only type in the file; if there are multiple types, I see the other types, but not the record.

[CyrusNajmabadi]

Go-to-all:

(it's a record)

Solution explorer:

Looks like a class.

Change namespace:

Move to namespace:

[thomaslevesque]

Wow... are you on 16.8.1 too? I'm seeing this bug on 2 different machines with a fresh VS install.
I just tried again in a different project, and I still have the same issue. As soon as I change the record to a class, the issue disappears.

[CyrusNajmabadi]

No, i'm on 16.9preview2 :)

[thomaslevesque]

Ah. Well, at least it's fixed in the next version... Any chance of getting the fix before 16.9 RTM?

[CyrusNajmabadi]

There is no chance of that happening.

[silkfire]

@CyrusNajmabadi Is the missing CodeLens reference bug (this issue) fixed in 16.9 too?

[PathogenDavid]

@silkfire I can confirm that it is not. (At least not in 16.9 preview 2.)

[magnusbakken]

Yeah, I just installed 16.9, and the CodeLens data is still missing for records.

[behzad888]

I just installed 16.9.1, and the CodeLens data is still missing for records too.

[bfren]

Anyone know if this is even being worked on at MS? It seems possibly only a minor thing, but actually for stuff like code coverage in tests codelens is invaluable to see at a glance what needs looking at.

[CyrusNajmabadi]

This currently is not assigned to anyone. We'd need to move it out of our backlog and into a particular release to make this happen.

[CyrusNajmabadi]

I'll see if i can make some time in the weekend to get this working.

[CyrusNajmabadi]

This has been fixed and is in the latest vs (internal) previews:

Fixed with: https://devdiv.visualstudio.com/DevDiv/_git/a290117c-5a8a-40f7-bc2c-f14dbe3acf6d/pullrequest/279270

Should be in 16.10