Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for record structs in CodeLens #52430

Closed
jcouv opened this issue Apr 6, 2021 · 3 comments
Closed

Add support for record structs in CodeLens #52430

jcouv opened this issue Apr 6, 2021 · 3 comments
Labels
Area-IDE Concept-Continuous Improvement New Language Feature - Records Records
Milestone
Backlog

Comments

@jcouv
Copy link
Member

jcouv commented Apr 6, 2021

We'll need something like https://devdiv.visualstudio.com/DevDiv/_git/a290117c-5a8a-40f7-bc2c-f14dbe3acf6d/pullrequest/279270 (from issue #47445) for record structs.

Relates to test plan for record structs: #51199
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 6, 2021
@jcouv jcouv mentioned this issue Apr 6, 2021
Closed
92 tasks
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 7, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Apr 7, 2021
@jcouv
Copy link
Member Author

jcouv commented Sep 23, 2021

@CyrusNajmabadi You'd fixed CodeLens for records (see links in OP). Do we need to do anything more along the same lines for record structs?

@CyrusNajmabadi
Copy link
Member

I don't believe so. The

        public override void VisitRecordDeclaration(RecordDeclarationSyntax node)
            => VisitTypeDeclaration(node);

case should handle record structs.

@jcouv
Copy link
Member Author

jcouv commented Sep 23, 2021

Awesome. I'll go ahead and close this then.

@jcouv jcouv closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Continuous Improvement New Language Feature - Records Records
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@CyrusNajmabadi @jinujoseph @jcouv