Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn Test CustomizableTagsForUnnecessaryCode #48671

Closed
runfoapp bot opened this issue Oct 16, 2020 · 5 comments · Fixed by #48800
Closed

Roslyn Test CustomizableTagsForUnnecessaryCode #48671

runfoapp bot opened this issue Oct 16, 2020 · 5 comments · Fixed by #48800
Assignees
@sharwell
Labels
Area-IDE Flaky Test Test failures in roslyn-CI
Milestone
Backlog

Comments

@runfoapp
Copy link

runfoapp bot commented Oct 16, 2020 •
edited
Loading

Runfo Tracking Issue: Roslyn Test CustomizableTagsForUnnecessaryCode

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 16, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@jaredpar jaredpar added Area-IDE Test Test failures in roslyn-CI labels Oct 16, 2020
@sharwell
Copy link
Member

Not this again

@jinujoseph jinujoseph added Flaky and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 20, 2020
@jinujoseph jinujoseph added this to the 16.9 milestone Oct 20, 2020
sharwell added a commit to sharwell/roslyn that referenced this issue Oct 20, 2020
@sharwell
Use an iterative wait in DiagnosticTaggerWrapper
ed0acf9 
This change ensures asynchronous operations in "earlier" stages which
are triggered by later stages still cause the test to wait for full
completion. The wait is complete when reaching a state where no pending
tasks are in any category of interest.

Fixes dotnet#48671
@sharwell sharwell mentioned this issue Oct 20, 2020
Merged
@sharwell sharwell added the 4 - In Review A fix for the issue is submitted for review. label Oct 20, 2020
@ghost ghost closed this as completed in #48800 Oct 21, 2020
@jaredpar
Copy link
Member

Reactivating because this is still impacting our builds even with the fix merged

@jaredpar jaredpar reopened this Oct 22, 2020
@Youssef1313
Copy link
Member

@jaredpar The "In Review" label looks extra which could prevent someone from looking into the issue.

@jaredpar jaredpar removed the 4 - In Review A fix for the issue is submitted for review. label Jan 26, 2021
@jinujoseph jinujoseph modified the milestones: 16.9, 16.10 Mar 28, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
@jaredpar
Copy link
Member

Closing due to no recent hits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Flaky Test Test failures in roslyn-CI
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Use an iterative wait in DiagnosticTaggerWrapper sharwell/roslyn
5 participants
@jaredpar @sharwell @jinujoseph @Youssef1313 @Dotnet-GitSync-Bot