Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IWorkspaceStatusService.IsFullyLoadedAsync synchronous #49114

Closed
davidwengier opened this issue Nov 1, 2020 · 2 comments · May be fixed by #49127
Closed

Make IWorkspaceStatusService.IsFullyLoadedAsync synchronous #49114

davidwengier opened this issue Nov 1, 2020 · 2 comments · May be fixed by #49127
Assignees
@sharwell
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Concept-Continuous Improvement
Milestone
Backlog

Comments

@davidwengier
Copy link
Contributor

Follow up from #48215

This pattern is used in a couple of places to make checking if a solution is fully loaded easier:
https://github.com/dotnet/roslyn/blob/master/src/EditorFeatures/Core/Implementation/Classification/SemanticClassificationUtilities.cs#L168-L174

Lets just formalize that pattern and make the property synchronous.

/cc @sharwell
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 1, 2020
@sharwell sharwell mentioned this issue Nov 2, 2020
Open
@sharwell sharwell added 4 - In Review A fix for the issue is submitted for review. Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 2, 2020
@sharwell sharwell self-assigned this Nov 2, 2020
sharwell added a commit to sharwell/roslyn that referenced this issue Nov 2, 2020
@sharwell
Make IWorkspaceStatusService.IsFullyLoadedAsync a synchronous property
f3c695f 
This change also removes a workaround for microsoft/vs-threading#696
that is no longer necessary.

Closes dotnet#49114
@jinujoseph jinujoseph added this to the 16.9 milestone Nov 4, 2020
@jinujoseph jinujoseph modified the milestones: 16.9, 16.10 Mar 28, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
@CyrusNajmabadi
Copy link
Member

@sharwell can we do this now?

@CyrusNajmabadi
Copy link
Member

Closing out due to lack of response. if we need to do this, please assign to a milestone.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

🧹 Services cleanup following previous review sharwell/roslyn
5 participants
@davidwengier @sharwell @CyrusNajmabadi @jinujoseph @Dotnet-GitSync-Bot