Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild does not handle visual basic my templates #51873

Closed
jaredpar opened this issue Mar 15, 2021 · 0 comments
Closed

Rebuild does not handle visual basic my templates #51873

jaredpar opened this issue Mar 15, 2021 · 0 comments
Assignees
@jaredpar
Labels
Area-Infrastructure Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Milestone
16.10

Comments

@jaredpar
Copy link
Member

The rebuild provenance for Visual Basic does not handle templates correctly. The rebuild is working within our code base because we have the VB runtime embedded in all cases which suppresses the my templates. Once that is turned off though our rebuild mis-handles them in the rebuild compilation.
@jaredpar jaredpar added Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations labels Mar 15, 2021
@jaredpar jaredpar added this to the 16.10 milestone Mar 15, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 15, 2021
@jaredpar jaredpar mentioned this issue Mar 15, 2021
Merged
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 15, 2021
@jaredpar jaredpar assigned jaredpar and unassigned RikkiGibson Mar 15, 2021
jaredpar added a commit to jaredpar/roslyn that referenced this issue Mar 16, 2021
@jaredpar
Fix rebuild round trip in unit tests
66691d9 
This changes the rebuild unit tests to fully round trip the
`Compilation` they are building and verify the output byte for byte
matches the input.

Issue dotnet#51873 discovered working on the change
jaredpar added a commit to jaredpar/roslyn that referenced this issue Mar 16, 2021
@jaredpar
Fix My template bug
bbd4e56 
The parse options weren't correctly being hooked up to the
`CompilationOptions` and that was breaking round tripping

closes dotnet#51873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredpar jaredpar

Labels
Area-Infrastructure Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Projects
None yet
Milestone
16.10
Development

No branches or pull requests
2 participants
@jaredpar @RikkiGibson