Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some checks around nullable related attributes are not performed for user defined operators #53069

Open
AlekseyTs opened this issue Apr 30, 2021 · 2 comments
Open

Some checks around nullable related attributes are not performed for user defined operators #53069

AlekseyTs opened this issue Apr 30, 2021 · 2 comments
Labels
Area-Compilers Bug Concept-Null Annotations The issue involves annotating an API for nullable reference types New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
Backlog

Comments

@AlekseyTs
Copy link
Contributor

SourceUserDefinedOperatorSymbolBase.AfterAddingTypeMembersChecks doesn't delegate to base and misses the check for nullable context attribute (performed in SourceMemberMethodSymbol.AfterAddingTypeMembersChecks). @cston confirms that this is an oversight.
@AlekseyTs AlekseyTs added Bug Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types Concept-Null Annotations The issue involves annotating an API for nullable reference types labels Apr 30, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 30, 2021
@AlekseyTs AlekseyTs mentioned this issue Apr 30, 2021
Merged
@Youssef1313
Copy link
Member

Youssef1313 commented May 1, 2021 •
edited
Loading

Related to #52259. (See below comment - Thanks for clarifying @AlekseyTs - I assumed they're related based on the title)

@AlekseyTs
Copy link
Contributor Author

AlekseyTs commented May 1, 2021 •
edited
Loading

@Youssef1313 Are you sure this is related to #52259? This issue is about attributes that are used to record nullable annotations in metadata. Failure to perform checks around them is likely to cause an emit failure in some error condition rather than a failure in the nullable analysis.

AlekseyTs added a commit that referenced this issue May 3, 2021
@AlekseyTs
Introduce a common base type for SourceOrdinaryMethodSymbolBase and S…
de19e26 
…ourceUserDefinedOperatorSymbolBase to prepare for explicit implementations of operators (#53058)

Shared code is pulled from derived types to the new base. This is just a refactoring, no behavior changes intended.

However, there is a change in behavior that addresses #53069.
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 13, 2021
@jaredpar jaredpar added this to the Backlog milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Concept-Null Annotations The issue involves annotating an API for nullable reference types New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @AlekseyTs @Youssef1313