EditorConfig UI enhancements

[Youssef1313]

• 1. Font currently feels too large compared with other UI elements (e.g, solution explorer). Opened Update EditorConfig UI font size to be consistent with VS environment settings #54599 to fix that.

  

• 2. New line preferences has a typo (Carrage return should be Carriage return) and probably no need to have double \ before r or n. Being fixed in Fix typo: Carrage -> Carriage #53327

  

• 3. The grid columns should by default be expanded to fit the content if there is a space.

• 4. "RemoveUnnecessaryImportsFixable" shouldn't probably exist on UI since it has "NotConfigurable" custom tag. (applies to IDE0005_gen as well)

  

  Proposed fix is to add GetConfigurableDiagnosticDescriptors similar to GetNonCompilationEndDiagnosticDescriptors and call it here. (Disable severity combobox for non-configurable rules #53175)

• 5. CA2016 is duplicated for some reason:

  

• 6. I'm not sure if the Category column is necessary, since the category is apparent from the parent node anyway. I also see that RS1023 is duplicated, so it seems like the previous point is general, wasn't specific to CA2016.

  

• 7. For some reason, I don't see any changes I make in UI in the actual .editorconfig text

Note: I was using Roslyn.sln while experimenting.

[Youssef1313]

@jmarolf

[jinujoseph]

cc @jmarolf
#2, #4, #5 could make it into 16.11
#7 is a priority bug if its reproducible

[jmarolf]

I'll investigate 7 today

[Youssef1313]

I'll investigate 7 today

For reference, here are the steps I've done (I didn't have VS Preview on the machine I was working on - so I used main build):

• Open Roslyn.sln using non-preview VS
• Set build configuration to Release and set RoslynDeployment as startup project.
• CTRL+F5 to start without debugging.
• Opened Roslyn.sln in the second VS instance.
• Opened .editorconfig by double clicking under Solution Items in Solution Explorer.

[jmarolf]

What specific items were not saved? or did literally nothing work?

[Youssef1313]

@jmarolf What I have tried was changing a few severities from code style tab. Haven't tried something else.

[jmarolf]

Can you list the exact repo steps please? That would help a lot.

[Youssef1313]

Is #53171 (comment) missing anything?

[jmarolf]

Which options? What did you set them to? how did you view the results? Did the editor mark the file as dirty or did nothing happen?

[Youssef1313]

@jmarolf I believe I have tried lots of options from code style tab with different values (so you could say it wasn't working at all for me when I tried). After modifying from UI, I attempted to save (while I could see there was no asterisk next to editorconfig file name - which means that no unsaved changes exists). Then, I did a git status to see if there are any changes to editorconfig, but there wasn't.

I'll check tomorrow if I could reproduce again.

Anything I can do if I was able to reproduce?

[jmarolf]

Looking into this today, it appears that a sequence of changes can cause the editor and the file buffer to get "out of sync". Unclear what the root cause is yet

[DotJoshJohnson]

I just ran into item 7 today. Fresh install of VS 2022, new project, new .editorconfig. I tried changing the "Namespace declarations" settings to "File scoped" and the underlying .editorconfig file was not changed.

[yodasad]

Yes, I ran into the item 7 too, fresh install of VS 2022, new project, new .editorconfig.

[Youssef1313]

@jmarolf @jinujoseph Can this be prioritized?

[Sergio0694]

I had the same issue the other day when I tried using the UI. Actually I could swear that in my case it not only not save the settings correctly, but it also kept resetting them back to some other values, seemingly at random. I just gave up and started editing the .editorconfig file manually after a bit 😅

[Eli-Black-Work]

Ran into #7 with a fresh VS2022 install as well 🙂

[TheBeardedLlama]

Ran into point 7 too
VS2019 16.11.3

I was changing values in the Code Analyzers tab.
No asterisk to indicate values had changed and nothing happened when hitting save.
File remains the same as before.

[Nicholas-Westby]

I am also experiencing point 7 (editorconfig UI doesn't update the .editorconfig file). Here's the current commit I'm working with: https://github.com/rhythmagency/formulate/tree/48aa47296ad72477fef64f45899a3633054c1899

Here's the solution you can open: https://github.com/rhythmagency/formulate/blob/48aa47296ad72477fef64f45899a3633054c1899/src/Formulate.sln

Here's the editor config file: https://github.com/rhythmagency/formulate/blob/48aa47296ad72477fef64f45899a3633054c1899/src/.editorconfig

Here's a screenshot that shows the two items I attempted to change:

I tried CTRL+S, File Save, File Save As, and File Save All. None of them caused the file to be updated.

Note also that it shows the location as "Visual Studio Settings". At one point, that changed to list the path to the actual .editorconfig file in the solution, but I haven't been able to reproduce that again.

I'm using Visual Studio Professional 2022 64-bit version 17.0.4. I do not have Visual Studio 2019 installed (this is a pretty new machine). I'm using Windows 11. I think .Net 6 is installed and that .Net 5 is not installed. At least, I think when creating new projects in Visual Studio I'm only given .Net 6 as an option.

I was able to confirm that manually editing the .editorconfig file shows the file as updated in my Git GUI tool (SmartGit).

[jmarolf]

closing this in favor of tracking individual bugs