Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Responsiveness] CodeModelState synchronously retrieves MEF services on UI thread (650ms immediately after solution load) #54159

Closed
davkean opened this issue Jun 17, 2021 · 0 comments · Fixed by #54187
Closed

[Responsiveness] CodeModelState synchronously retrieves MEF services on UI thread (650ms immediately after solution load) #54159

davkean opened this issue Jun 17, 2021 · 0 comments · Fixed by #54187
Assignees
@sharwell
Labels
Area-IDE Area-Performance Concept-Continuous Improvement Performance-Scenario-Responsiveness Performance issues related to UI responsiveness Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
17.0.P2

Comments

@davkean
Copy link
Member

davkean commented Jun 17, 2021

Version Used:
17.0.0 Preview 1.0 [31401.12.main]

Trace (1404 projects)

This constructor path appears to not have any thread affinity, can we move it to a background thread?

image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 17, 2021
@davkean davkean changed the title [Responsiveness] CodeModelState synchronously retrieves MEF service on UI thread (650ms immediately after solution load) [Responsiveness] CodeModelState synchronously retrieves MEF services on UI thread (650ms immediately after solution load) Jun 17, 2021
@davkean davkean added Area-Performance Performance-Scenario-Solution-Open This issue affects solution open performance. Performance-Scenario-Responsiveness Performance issues related to UI responsiveness and removed Performance-Scenario-Solution-Open This issue affects solution open performance. labels Jun 17, 2021
@sharwell sharwell self-assigned this Jun 17, 2021
sharwell added a commit to sharwell/roslyn that referenced this issue Jun 17, 2021
@sharwell
Initialize MEF services before switching to the main thread
7d1ea1b 
Fixes dotnet#54159
@sharwell sharwell removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 17, 2021
@sharwell sharwell mentioned this issue Jun 17, 2021
Merged
@sharwell sharwell added the 4 - In Review A fix for the issue is submitted for review. label Jun 17, 2021
@jinujoseph jinujoseph added this to the 17.0.P2 milestone Jun 17, 2021
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Jun 20, 2021
@sharwell sharwell modified the milestones: 17.0.P2, Next Jun 20, 2021
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Area-Performance Concept-Continuous Improvement Performance-Scenario-Responsiveness Performance issues related to UI responsiveness Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
17.0.P2
Development

Successfully merging a pull request may close this issue.

Initialize MEF services before switching to the main thread sharwell/roslyn
4 participants
@davkean @sharwell @RikkiGibson @jinujoseph