Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement interface abstractly should not apply to static members #54328

Closed
sharwell opened this issue Jun 23, 2021 · 1 comment · Fixed by #53941
Closed

Implement interface abstractly should not apply to static members #54328

sharwell opened this issue Jun 23, 2021 · 1 comment · Fixed by #53941
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings New Feature - StaticAbstractMembersInInterfaces
Milestone
17.0

Comments

@sharwell
Copy link
Member

Implementations of static abstract members in an interface cannot be abstract themselves. Implement Interface Abstractly should perform one of the following actions instead:

  1. Omit static abstract members declared in the interface (they can be implemented by a subsequent "Implement remaining members" action).
  2. Include implementations for static abstract members, but give them an implementation instead of marking them abstract.
@sharwell sharwell added Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-IDE IDE-CodeStyle Built-in analyzers, fixes, and refactorings New Feature - StaticAbstractMembersInInterfaces labels Jun 23, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 23, 2021
@sharwell sharwell mentioned this issue Jun 23, 2021
Merged
@Youssef1313
Copy link
Member

Doing that in #53941.

@sharwell sharwell added 4 - In Review A fix for the issue is submitted for review. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 23, 2021
@sharwell sharwell added this to the 17.0 milestone Jun 23, 2021
@Youssef1313 Youssef1313 mentioned this issue Jun 23, 2021
Merged
@jinujoseph jinujoseph removed the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings New Feature - StaticAbstractMembersInInterfaces
Projects
None yet
Milestone
17.0
Development

Successfully merging a pull request may close this issue.

Adjust implement interface service to work with static abstract operators Youssef1313/roslyn
3 participants
@sharwell @jinujoseph @Youssef1313