Implement interface tests #54310
Implement interface tests #54310
Conversation
| @"interface IInterface | ||
| { | ||
| [return: System.Runtime.CompilerServices.TupleElementNames(new[] { ""a"", ""b"" })] | ||
| [return: {|CS8138:System.Runtime.CompilerServices.TupleElementNames(new[] { ""a"", ""b"" })|}] |
There was a problem hiding this comment.
💭 It's not clear that this is an accurate representation.
| { | ||
| p public void Method() | ||
| p {|CS1585:public|} void Method() |
There was a problem hiding this comment.
📝 In this case, the code fix is missing because CS0535 is not reported on the ITest identifier. If there is a different syntax which produces incomplete member errors but still produces CS0535, the results might be different than this test.
| Options = { AllOptionsOff }, | ||
|
|
||
| // 🐛 one value is generated with 0U instead of 0 | ||
| CodeActionValidationMode = CodeActionValidationMode.None, |
There was a problem hiding this comment.
📝 There are a few cases where validation needed to be disabled for this code fix. I'll file a follow-up issue to review them.
| @@ -5094,7 +5132,7 @@ interface I | |||
|
|
|||
| class C : I | |||
| { | |||
| public void Goo([DefaultParameterValue(1), Optional] int x = 1, int[,] y = null) | |||
| public void Goo([{|CS1745:DefaultParameterValue|}(1), {|CS1745:Optional|}] int x = {|CS8017:1|}, int[,] y = null) | |||
There was a problem hiding this comment.
🐛 this code generation is not correct. I'm guess the result we want is:
| public void Goo([{|CS1745:DefaultParameterValue|}(1), {|CS1745:Optional|}] int x = {|CS8017:1|}, int[,] y = null) | |
| public void Goo(int x = 1, int[,] y = null) |
| // Specify the code action by equivalence key only to avoid trying to implement the interface explicitly with a second code fix pass. | ||
| CodeActionEquivalenceKey = "False;False;True:global::IInterface;Assembly1;Microsoft.CodeAnalysis.ImplementInterface.AbstractImplementInterfaceService+ImplementInterfaceCodeAction;", |
There was a problem hiding this comment.
📝 The test library could be improved for this case (only require matching key/index if the key appears somewhere in the list of available code actions, plus require the first pass have a matching pair). I'll file a follow-up issue in dotnet/roslyn-sdk.
There was a problem hiding this comment.
| // /0/Test0.cs(7,11): error CS0535: 'C' does not implement interface member 'ITest.M1()' | ||
| DiagnosticResult.CompilerError("CS0535").WithLocation(0).WithArguments("C", "ITest.M1()"), | ||
| // /0/Test0.cs(9,16): error CS0539: 'C.M1()' in explicit interface declaration is not found among members of the interface that can be implemented | ||
| DiagnosticResult.CompilerError("CS0539").WithLocation(1).WithArguments("C.M1()"), |
There was a problem hiding this comment.
🐛 The generated code is missing a static modifier, which leads to errors. Will file a follow-up issue.
| ExpectedDiagnostics = | ||
| { | ||
| // /0/Test0.cs(9,33): error CS0112: A static member cannot be marked as 'abstract' | ||
| DiagnosticResult.CompilerError("CS0112").WithLocation(0).WithArguments("abstract"), |
There was a problem hiding this comment.
🐛 Static members cannot be generated abstractly. Will file a follow-up issue.
There was a problem hiding this comment.
@sharwell I believe I already fixed this in a PR that's not yet merged.
ghost
added this to the 
No description provided.