Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn projects failing to build in source-build bootstrap build #57342

Closed
dseefeld opened this issue Oct 23, 2021 · 2 comments
Closed

Roslyn projects failing to build in source-build bootstrap build #57342

dseefeld opened this issue Oct 23, 2021 · 2 comments
Assignees
@jmarolf
Labels
Area-Infrastructure Bug Contributor Pain The issue impedes progress for project collaborators.

Comments

@dseefeld
Copy link
Contributor

When building roslyn in a bootstrapped source-build scenario (i.e. building with a version of the SDK that has been previously source-built), any projects with <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> fail to build. These are failing because source-build does not build the WindowsDesktop SDK. These projects are attempting to be excluded using <ExcludeFromSourceBuild>, but this fails because the project still needs to be loaded to access the property. These projects will need to be excluded using a different method for source-build. In the interim, a patch has been created including a .slnf file which excludes these projects.

src/EditorFeatures/CSharpTest2/Microsoft.CodeAnalysis.CSharp.EditorFeatures2.UnitTests.csproj
src/EditorFeatures/TestUtilities/Microsoft.CodeAnalysis.EditorFeatures.Test.Utilities.csproj
src/Interactive/Host/Microsoft.CodeAnalysis.InteractiveHost.csproj
src/Interactive/HostProcess/InteractiveHost32.csproj
src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj
src/VisualStudio/Core/Impl/Microsoft.VisualStudio.LanguageServices.Implementation.csproj
src/VisualStudio/CSharp/Impl/Microsoft.VisualStudio.LanguageServices.CSharp.csproj
src/VisualStudio/CSharp/Test/Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.csproj
src/EditorFeatures/Test/Microsoft.CodeAnalysis.EditorFeatures.UnitTests.csproj
src/EditorFeatures/CSharpTest/Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests.csproj
src/VisualStudio/VisualStudioDiagnosticsToolWindow/Roslyn.VisualStudio.DiagnosticsWindow.csproj
src/Test/Diagnostics/Roslyn.Hosting.Diagnostics.csproj
src/VisualStudio/IntegrationTest/TestUtilities/Microsoft.VisualStudio.IntegrationTest.Utilities.csproj
src/Workspaces/CoreTestUtilities/Microsoft.CodeAnalysis.Workspaces.Test.Utilities.csproj
src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj
src/Interactive/HostProcess/InteractiveHost64.csproj
src/Workspaces/DesktopTest/Microsoft.CodeAnalysis.Workspaces.Desktop.UnitTests.csproj
src/EditorFeatures/DiagnosticsTestUtilities/Microsoft.CodeAnalysis.EditorFeatures.DiagnosticsTests.Utilities.csproj
src/EditorFeatures/VisualBasicTest/Microsoft.CodeAnalysis.VisualBasic.EditorFeatures.UnitTests.vbproj
src/EditorFeatures/Test2/Microsoft.CodeAnalysis.EditorFeatures2.UnitTests.vbproj
src/VisualStudio/VisualBasic/Impl/Microsoft.VisualStudio.LanguageServices.VisualBasic.vbproj
src/VisualStudio/Core/Test/Microsoft.VisualStudio.LanguageServices.UnitTests.vbproj
src/VisualStudio/TestUtilities2/Microsoft.VisualStudio.LanguageServices.Test.Utilities2.vbproj
src/EditorFeatures/TestUtilities2/Microsoft.CodeAnalysis.EditorFeatures.Test.Utilities2.vbproj
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 23, 2021
@dagood
Copy link
Member

dagood commented Oct 25, 2021

Here's the PR adding the patch that does this: dotnet/installer#12500.

@MichaelSimons MichaelSimons mentioned this issue Oct 25, 2021
Merged
@jinujoseph jinujoseph added Bug Contributor Pain The issue impedes progress for project collaborators. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 27, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Oct 27, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Dec 10, 2021
lbussell pushed a commit to lbussell/roslyn that referenced this issue Jan 7, 2022
@dseefeld @lbussell
Build a subset of roslyn projects
000e267 
Some projects use Microsoft.NET.Sdk.WindowsDesktop sdk
which cannot be built using a boostrapped source-build
sdk, since WindowsDesktop is not supported.  These cannot
be ignored using ExcludeFromSourceBuild because the project
still needs to be loaded and the sdk cannot be found.

See dotnet#57342
lbussell pushed a commit to lbussell/roslyn that referenced this issue Jan 7, 2022
@dseefeld @lbussell
build a subset of roslyn projects
187fbeb 
Some projects use Microsoft.NET.Sdk.WindowsDesktop sdk
which cannot be built using a boostrapped source-build
sdk, since WindowsDesktop is not supported.  These cannot
be ignored using ExcludeFromSourceBuild because the project
still needs to be loaded and the sdk cannot be found.

See dotnet#57342
lbussell pushed a commit to lbussell/roslyn that referenced this issue Jan 7, 2022
@dseefeld @lbussell
build a subset of roslyn projects
3d2485b 
Some projects use Microsoft.NET.Sdk.WindowsDesktop sdk
which cannot be built using a boostrapped source-build
sdk, since WindowsDesktop is not supported.  These cannot
be ignored using ExcludeFromSourceBuild because the project
still needs to be loaded and the sdk cannot be found.

See dotnet#57342
@lbussell lbussell mentioned this issue Jan 10, 2022
Merged
@jmarolf jmarolf modified the milestones: 17.1, 17.2 Jan 10, 2022
@lbussell lbussell mentioned this issue Jan 20, 2022
Merged
lbussell pushed a commit to lbussell/roslyn that referenced this issue Jan 25, 2022
@dseefeld @lbussell
build a subset of roslyn projects
f3142bf 
Some projects use Microsoft.NET.Sdk.WindowsDesktop sdk
which cannot be built using a boostrapped source-build
sdk, since WindowsDesktop is not supported.  These cannot
be ignored using ExcludeFromSourceBuild because the project
still needs to be loaded and the sdk cannot be found.

See dotnet#57342
@lbussell
Copy link
Contributor

lbussell commented Feb 7, 2022

Fixed with dotnet/installer#13093.

@lbussell lbussell closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarolf jmarolf

Labels
Area-Infrastructure Bug Contributor Pain The issue impedes progress for project collaborators.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dseefeld @jmarolf @jinujoseph @dagood @lbussell