Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable MakeConst tests #5918

Closed
jaredpar opened this issue Oct 13, 2015 · 2 comments
Closed

Re-enable MakeConst tests #5918

jaredpar opened this issue Oct 13, 2015 · 2 comments
Assignees
@AnthonyDGreen
Labels
Area-Compilers Test Test failures in roslyn-CI
Milestone
Backlog

Comments

@jaredpar
Copy link
Member

The MakeConst VB and C# tests in our samples directory both have no tests in them. This means xunit runs very fast on the assemblies and appears to expose the following bug in EventListener

https://github.com/dotnet/corefx/issues/3793

This is causing our Jenkins runs to incorrectly fail. As a result I'm taking them out of the runs for now. These projects should either be updated to have tests or simply deleted altogether.
@jaredpar jaredpar added Area-Infrastructure Test Test failures in roslyn-CI labels Oct 13, 2015
@jaredpar jaredpar added this to the 1.2 milestone Oct 13, 2015
@jaredpar jaredpar mentioned this issue Oct 13, 2015
Merged
jaredpar added a commit to jaredpar/roslyn that referenced this issue Oct 13, 2015
@jaredpar
Disable MakeConst assemblies
0e230f9 
These unit test assemblies don't actually have any tests in them.  Running a DLL with no tests is exposing a bug in CoreFX and causing our Jenkins runs to fail.  Disabling them for now.

Issue dotnet#5918 is tracking this.
@davkean
Copy link
Member

davkean commented Oct 21, 2015

Moving this to compilers, as they own it, not infrastructure.

@davkean
Copy link
Member

davkean commented Oct 21, 2015

Oh, no sorry, these are samples. Who owns samples?

@jaredpar jaredpar modified the milestones: Unknown, 1.2 Nov 30, 2015
@jmarolf jmarolf mentioned this issue Jan 7, 2016
Merged
@jmarolf jmarolf closed this as completed in ecf6835 Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnthonyDGreen AnthonyDGreen

Labels
Area-Compilers Test Test failures in roslyn-CI
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @davkean @AnthonyDGreen