Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Rename breaks when deleting portion of identifier #60869

Closed
DustinCampbell opened this issue Apr 20, 2022 · 2 comments
Closed

Inline Rename breaks when deleting portion of identifier #60869

DustinCampbell opened this issue Apr 20, 2022 · 2 comments

Comments

@DustinCampbell
Copy link
Member

Version Used: Latest IntPreview

Steps to Reproduce:

  1. Create a long identifier.

    int IdentifierLotsOfWords = 42;
  2. Select a portion of the identifier.
    image

  3. Press F2 to start an Inline Rename
    image

  4. Press the DELETE key to delete the selected portion.

Expected Behavior: The selected portion of the identifier is deleted.

Actual Behavior: The rename is cancelled.

Note: Repeating steps 2-4 will eventually get Inline Rename in a bad state where the UI won't go away and there's a gold bar that reports a COMException. Here's the ActivityLog from session where this happened: ActivityLog.txt

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2022
@ryzngard
Copy link
Contributor

Does this reproduce is you manually put focus into the flyout? I have a feeling this is a case where focus should have been in the flyout and isn't. Likely fixed by #60846

@jinujoseph jinujoseph added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 28, 2022
@jinujoseph jinujoseph added this to the 17.3 milestone Apr 28, 2022
@vatsalyaagrawal vatsalyaagrawal modified the milestones: 17.3, Backlog Aug 2, 2022
@CyrusNajmabadi
Copy link
Member

Wasn't able to repro this on latest builds. We demonstrate the expected behavior

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants