Fix focus on rename UI opening #60846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Apr 20, 2022
src/EditorFeatures/Core.Wpf/InlineRename/CommandHandlers/RenameCommandHandler.cs
Outdated
Show resolved
Hide resolved
JoeRobich
approved these changes
Apr 21, 2022
JoeRobich
reviewed
Apr 29, 2022
| { | ||
| if (GetDashboard(textView) is { } dashboard) | ||
| if (GetAdornment(textView) is RenameDashboard dashboard) | ||
| { | ||
| dashboard.FocusNextElement(); |
There was a problem hiding this comment.
Should this be .FocusPreviousElement()
There was a problem hiding this comment.
oh it definitely should... idk what that will break though :) I'll file an issue to change it
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
May 16, 2022
…o poison * upstream/features/required-members: (413 commits) [EE] Implement IDkmClrFullNameProvider2 in Roslyn's ResultProvider Formatter. (dotnet#60522) Remove parameter null-checking from the Language Feature Status list (dotnet#61302) Add pointer for `AnalysisLevel` to warning waves doc (dotnet#61196) Add an UWP OptProf test for IDE Add test Fix issue where we were getting a raw-string in a skipped token, causing a crash Fix several LSP completion kind mappings (dotnet#61243) Relax assertion in SyntheticBoundNodeFactory.Convert (dotnet#61287) Enable add usings on paste by default (dotnet#61299) Fix focus on rename UI opening (dotnet#60846) Update PublishData.json with new package Remove Razor and editor inference document option providers (dotnet#61091) Fix nested in generic type binding issues in enabled nullability context (dotnet#61182) Revert "Revert "Improve editorconfig options caching on ProjectState (dotnet#61131)" (dotnet#61216)" (dotnet#61283) Move MSBuild back to 16.5.0. Fix a few build and package issues (dotnet#61273) lint Revert workspaces msbuild changes. Use SegmentedHashSet<T> to eliminate LOH allocations in AsyncBatchingWorkQueue NRT ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the new adornment would not focus correctly. This changes to use the Load event and calls focus on the control directly.
It also cleans up some wording and usage of "Dashboard", which is not always correct now.
Fixes #60035