Suggestion: Select the span automatically based on cursor position for introduce local / constant

[balajikris]

Ported from TFS WorkItem: 1065670, originally filed by @shyamnamboodiripad

---

Repro Steps:

Currently, I if I want to invoke introduce local /constant refactoring on a multiline string literal, I am forced to select the entire string first. It would be nice if I could invoke the refactoring by simply placing cursor somewhere in the string and hitting ctrl + . 

Can't we figure out the minimum enclosing span for the current cursor position (i.e. expand to span of innermost node / expression containing the cursor) and offer refactorings as if the user had selected this span? I could also imagine this being useful for other expressions (date literals, expressions / method calls involving long identifiers etc.)

Looks like we do this already in some other refactorings? For example, if i select jsut 'String' in the following If statement, I am offered an extract method refactoring that extracts the entire 'typeof x isnot string' expression-

Revision History:

1. Created By Shyam Namboodiripad (10/16/2014 11:22:37 PM)

2. Edited By Kevin Pilch-Bisson (10/17/2014 10:03:24 AM)

Can you think about the UX here?

3. Edited By Kevin Pilch-Bisson (2/20/2015 3:21:24 PM)

Yes, I think this is a good idea to help with our refactoring discoverability.  It may not fit in RTM though.  Can you port to GitHub.

[Pilchie]

Moving to 1.1.

[ryanbrandenburg]

Design Meeting Notes: Let's try this out with a service that lets the customer select an expression from a sub-list based on where their caret was when they invoked.

[sharwell]

This refactoring will use IRefactoringHelpersService to provide the span information for a position:

roslyn/src/Features/Core/Portable/CodeRefactorings/IRefactoringHelpersService.cs

Line 39 in d140d08

Task<ImmutableArray<TSyntaxNode>> GetRelevantNodesAsync<TSyntaxNode>(Document document, TextSpan selection, CancellationToken cancellationToken) where TSyntaxNode : SyntaxNode;

[CyrusNajmabadi]

Introduce constant is offered within a string literal: