Shorten Some Commonly Used Method Names.

[AdamSpeight2008]

Implementation of Issue #999

Note: Incudes #1001 (This is where this branch originated)
Note: Builds with Test Failure ##1006

[gafter]

@AlekseyTs Do you find this change an improvement?

[AlekseyTs]

I like the idea of renaming. There is one suggestion, "CanGet" should probably be "CanPeek".
It feels like the change itself introduces too much churn. I would prefer it to be straight rename, no reformatting of the code. For example, I do not find a change like the following (conversion to a single-line If) an improvement:

•                If CanGetCharAtOffset(1) AndAlso BeginsBaseLiteral(PeekAheadChar(1)) Then
  

•                    Return ScanNumericLiteral(precedingTrivia)
  

•                End If
  

•                If CanGet(1) AndAlso BeginsBaseLiteral(Peek(1)) Then Return ScanNumericLiteral(precedingTrivia)
  

Reformatting of conditions from multiple line to a single line fall into the same category, etc.

[gafter]

@AdamSpeight2008 Can you please update your pull request to address the comments from @AlekseyTs ?

[VladimirReshetnikov]

Could you please keep the newline after the OrElse in the condition.
Now I need to scroll right the diff on GitHub to see the end of the proposed line.

[gafter]

Please revert the formatting change here.

[AdamSpeight2008]

I will not revert the formatting changes. You can submit a PR and I consider it,

[AdamSpeight2008]

@KevinH-MS
Are you coming from a C# background? working with VB.
VB is predominately line orientated. Reading left to right to the end of the line.

IF ... Then ... you'll continue reading to the right.

If ... Then
...

You read L-R to the Then then move on to the next line. Maybe scanning forward to find the Else or `End If' to gauge the size of the block.

There is (currently) isn't any restriction on the width of the source. Also no font size has been specified, or screen width. etc, etc. I tend to make that limit 80chars. If the single line version will fit within that limit then I'll use it, otherwise use the multi line implementation.

[gafter]

@AdamSpeight2008 This PR contains both the desired renames and a number of unrelated formatting changes. We would prefer to have just the renames. You are most welcome to reopen the PR if it has been narrowed to those changes.

[KevinH-MS]

@AdamSpeight2008
Quite the contrary, I've spent most of the past 10 years or so writing VB (and didn't really learn C# until ~2010). 😄
While you're certainly right in that VB/Basic are line/statement oriented languages, I would assert that since the advent of VB (early to mid 1990s), block ifs have been the norm (except for occasional use in argument validation). Part of this is because we haven't had a decent REPL for VB in years (but we're looking to change that). In any case, reasonable parties may disagree, and the above is mostly just my personal opinion. It is certainly the case, however, that block ifs are almost universally used across the Roslyn code base (so I would be disinclined to make changes unless they were broadly and consistently applied...and that should probably be a separate PR, as there is likely to be some debate...). Thanks

[AdamSpeight2008]

@gafter #1627