Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters for keywords and snippets. #14558

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Add filters for keywords and snippets. #14558

merged 1 commit into from
Oct 17, 2016

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #14528

@CyrusNajmabadi
Copy link
Member Author

Taggging @dotnet/roslyn-ide

@CyrusNajmabadi
Copy link
Member Author

Tagging @dotnet/roslyn-ide

Looks like this:

image

@CyrusNajmabadi
Copy link
Member Author

test this please

@Pilchie
Copy link
Member

Pilchie commented Oct 17, 2016

I'm a bit confused by your screenshot. It looks like the keyword filter is checked, but you're still seeing snippets and locals. Also, what is that empty entry at the top of the list?

@CyrusNajmabadi
Copy link
Member Author

I'm a bit confused by your screenshot. It looks like the keyword filter is checked

It wasn't checked. I was just hovering. Good call on the empty entry. I will go find out what's happening htere!

Pilchie
Pilchie approved these changes Oct 17, 2016
View reviewed changes
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then - glad it was an easy fix.

@CyrusNajmabadi CyrusNajmabadi merged commit b7d2e49 into dotnet:master Oct 17, 2016
@CyrusNajmabadi CyrusNajmabadi deleted the keywordSnippetFilters branch October 17, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@Pilchie Pilchie Pilchie approved these changes

Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @Pilchie @DustinCampbell @dnfclas