Some more automated tests and test cleanup for the PR#16659 #16805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#16659 added tests, made the included tuple2 chunk a CData
|
@dpoeschl - please review |
|
@dotnet/roslyn-compiler - FYI test-only change |
dpoeschl
approved these changes
Jan 28, 2017
| Dim input = | ||
| <Workspace> | ||
| <Project Language="C#" CommonReferences="true"> | ||
| <Document><
There was a problem hiding this comment.
I'm pretty sure you don't need these CDATAs here. Do you?
There was a problem hiding this comment.
CData is convenient since you can put more stuff in them without having to escape < and stuff like that. After that I just copied the test and changed the content where needed.
I think removing CDATA where not needed is not very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16659
added tests, made the included tuple2 chunk a CData
Test-only change.