Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report all invalid preprocessor symbols in diagnostics #17050

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Report all invalid preprocessor symbols in diagnostics #17050

merged 1 commit into from
Mar 14, 2017

Conversation

OmarTawfik
Copy link
Contributor

Fixes #16913
@dotnet/roslyn-compiler

@OmarTawfik OmarTawfik added this to the 2.1 milestone Feb 9, 2017
AlekseyTs
AlekseyTs approved these changes Feb 10, 2017
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmarTawfik
Copy link
Contributor Author

@jcouv you already signed off on #16920, but per comments on it, moving it to a separate PR because the other issue needs to be handled in a bigger change set. Can you please take a second look?

jcouv
jcouv approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@agocke agocke changed the base branch from post-dev15 to master February 14, 2017 23:23
@OmarTawfik OmarTawfik merged commit 5f1130c into dotnet:master Mar 14, 2017
@OmarTawfik OmarTawfik deleted the fix-16913-report-multiple-define-errors-small branch March 14, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
0 - Backlog Area-Compilers Bug cla-already-signed
Projects
None yet
Milestone
15.1
Development

Successfully merging this pull request may close these issues.
4 participants
@OmarTawfik @AlekseyTs @jcouv @dnfclas