Refine syntax error recovery for partial code to not interfere with non-error code. #17692
Conversation
…on-error code. Related to dotnet#15885 Fixes dotnet#17683
|
test windows_debug_vs-integration_prtest please |
|
@dotnet/roslyn-compiler @jaredpar @CyrusNajmabadi Please review this tiny correction to a recent change to error recovery. It addresses VSO 393733 |
| t == Int32. | ||
| MinValue | ||
| select t"; | ||
| UsingExpression(source); |
There was a problem hiding this comment.
UsingExpression(source); [](start = 12, length = 24)
Is there a way to assert that there is no errors?
There was a problem hiding this comment.
It looks like the helper is taking expected diagnostics as an optional parameter. So the errors are checked.
There was a problem hiding this comment.
The name of the helper doesn't really help the reader know that, though. I'll look at improving that in the future.
| MaxValue when true: | ||
| break; | ||
| }"; | ||
| UsingStatement(source); |
There was a problem hiding this comment.
UsingStatement(source); [](start = 12, length = 23)
Is there a way to assert that there is no errors?
There was a problem hiding this comment.
It looks like the helper is taking expected diagnostics as an optional parameter. So the errors are checked.
|
@dotnet/roslyn-compiler May I please have a second review? |
2 similar comments
|
@dotnet/roslyn-compiler May I please have a second review? |
|
@dotnet/roslyn-compiler May I please have a second review? |
|
LGTM |
|
👍 |
Related to #15885
Fixes #17683
@CyrusNajmabadi Would you like to have a look at this before I send it out for review?