Skip updating signature-help if there's another update request in the update-queue. #17772
Conversation
|
Tagging @dotnet/roslyn-ide |
|
@Pilchie Can you try this with your scenario where you saw SignatureHelp slowdowns? |
…ilter out a command that has data we might need.
| /// we keep track if there is new outstanding retrigger command and we bail on the | ||
| /// computation if another is in the queue. | ||
| /// </summary> | ||
| private int _retriggerId; |
There was a problem hiding this comment.
Does this need to be marked volatile? I can never remember.
| (triggerInfo.TriggerCharacter.HasValue && !currentModel.Provider.IsRetriggerCharacter(triggerInfo.TriggerCharacter.Value))) | ||
| if (currentModel == null) | ||
| { | ||
| return currentModel; |
| /// previous model we've computed. | ||
| /// </summary> | ||
| private async Task<(ISignatureHelpProvider provider, SignatureHelpItems items)?> ComputeItemsAsync( | ||
| int id, |
There was a problem hiding this comment.
Can we call this retriggerId or something so it's clear it relates to the other field? id is a bit vague.
There was a problem hiding this comment.
This is basically duplicating the pattern used in http://source.roslyn.io/#Microsoft.CodeAnalysis.EditorFeatures/Implementation/Intellisense/Completion/Controller.Session_FilterModel.cs,63002199f3349dd6 . Any way we could push the filterId stuff up into the ChainModelAndNotify... infrastructure?
|
@rchande The issue is that skipping is very scenario specific. You only want to skip for certain types of messages, when you know it's totally safe to do so. For example, you can't skip a retrigger that is based on a typed-char, because the next retrigger might be for a different character which may lead to different results. |
|
Finally gave this a try with release bits today and it definitely feels much better! Thanks @CyrusNajmabadi |
No description provided.