check remote host being available. #17835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when host is shutting down it is possible GetRemoteHostClient return null even though host itself support remote hosting.
|
@CyrusNajmabadi can you take a look? |
|
fix #17768 |
| @@ -76,7 +76,11 @@ private class RemoteUpdateEngine : ISymbolSearchUpdateEngine | |||
| _sessionDoNotAccessDirectly = null; | |||
|
|
|||
| _client = await _workspace.GetRemoteHostClientAsync(CancellationToken.None).ConfigureAwait(false); | |||
| _client.ConnectionChanged += OnConnectionChanged; | |||
There was a problem hiding this comment.
are there other people that might observe that the client returned by GetRemoteHostClientAsync could be null?
CyrusNajmabadi
approved these changes
Mar 14, 2017
|
sure |
…it clear that it can return null when remote host is not available. left GetRemotehostClientAsync there as Obsolete so that this doesnt break other team such as LUT. will remove it once other team moved to new bits.
|
tagging @KevinH-MS I renamed GetRemoteHostClientAsync to TryGetRemoteHostClientAsync |
|
retest windows_release_vs-integration_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when host is shutting down it is possible GetRemoteHostClient return null even though host itself support remote hosting.