Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No scrollbar in Code Style preview pane #17844

Merged
merged 2 commits into from
Apr 5, 2017
Merged

No scrollbar in Code Style preview pane #17844

merged 2 commits into from
Apr 5, 2017

Conversation

stefannikolei
Copy link
Contributor

Fixes #17679

Before:
image

After:
image

@Pilchie
Copy link
Member

Pilchie commented Mar 14, 2017

Thanks @reaction1989! @dotnet/roslyn-ide can you review. @KirillOsenkov @olegtk do you know of any other effects of switching to the Interactive role?

@jasonmalinowski
Copy link
Member

I think it also means you'll get a caret, which isn't really terrible.

jasonmalinowski
jasonmalinowski reviewed Mar 14, 2017
View reviewed changes
src/VisualStudio/Core/Impl/Options/AbstractOptionPreviewViewModel.cs
@@ -173,7 +173,7 @@ public void UpdatePreview(string text)
LineSpan.FromBounds(startLine, endLine));

var textView = _textEditorFactoryService.CreateTextView(projection,
_textEditorFactoryService.CreateTextViewRoleSet(PredefinedTextViewRoles.Analyzable));
_textEditorFactoryService.CreateTextViewRoleSet(PredefinedTextViewRoles.Interactive));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need Analyzable as well? Otherwise we might lose classification or other tagging.

@CyrusNajmabadi
Copy link
Member

Does this make the view editable?

@stefannikolei
Copy link
Contributor Author

Nope it can not be edited. Side effect is that you get an caret and that you are able to mark the code. But it is not possible to copy it

@CyrusNajmabadi
Copy link
Member

Note: many of our samples would technically have errors in them (due to duplicated symbols). Can we verify that we don't show squiggles here?

@stefannikolei
Copy link
Contributor Author

@CyrusNajmabadi I made my way through all examples in this pane. There were no squiggles

dpoeschl
dpoeschl approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@dpoeschl dpoeschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally. Looks good to me.

@dpoeschl dpoeschl merged commit 519c7ba into dotnet:master Apr 5, 2017
@dpoeschl
Copy link
Contributor

dpoeschl commented Apr 5, 2017

Thanks @reaction1989!

@stefannikolei stefannikolei deleted the PreviewPaneScrollbar branch May 14, 2017 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@dpoeschl dpoeschl dpoeschl approved these changes

Assignees
No one assigned
Labels
Area-IDE cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefannikolei @Pilchie @jasonmalinowski @CyrusNajmabadi @dpoeschl @dnfclas