Fix a break in perf runs

[jaredpar]

No description provided.

[jaredpar]

test perf please

[jaredpar]

CC @rchande, @jasonmalinowski, @TyOverby

Will merge once perf test is green.

[rchande]

Note that Jenkins will mark the run as green even if the error I mentioned occurs. Can you ping me when you're ready to merge and I'll look at the logs and verify it's actually working? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Jared Parsons <notifications@github.com> Sent: Tuesday, March 14, 2017 2:30:47 PM To: dotnet/roslyn Cc: Ravi Chande; Mention Subject: Re: [dotnet/roslyn] Fix a break in perf runs (#17855) CC @rchande<https://github.com/rchande>, @jasonmalinowski<https://github.com/jasonmalinowski>, @TyOverby<https://github.com/TyOverby> Will merge once perf test is green. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#17855 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADk96QIY2iYe1ANcQNAS-m38F_butuhZks5rlwcHgaJpZM4MdK8E>.

[jaredpar]

@rchande

Note that Jenkins will mark the run as green even if the error I mentioned occurs

Sounds like something we should fix

Log is ready to view.

[rchande]

@jaredpar So there aren't any errors from PowerShell but it still looks like the perf runner isn't getting invoke. @TyOverby any ideas?

[rchande]

It also looks like we aren't installing the BenchView tools. Are we actually entering the body of the conditional on line 109?

[jaredpar]

@rchande think I figured out the conditional issue. Pushed another change.

[rchande]

test perf please

[rchande]

@jaredpar , still seeing issues:

15:47:47 The term 'env:GIT_BRANCH' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
15:47:47 System.Management.Automation.CommandNotFoundException: The term 'env:GIT_BRANCH' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
15:47:47    at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
15:47:47    at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
15:47:47    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
15:47:47    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)

[jaredpar]

test perf please

[rchande]

@jaredpar Looks like we're producing results now, but none of the perf subsystem's logs are appearing in the console output. Any idea what's up with that?

[jaredpar]

test perf please

[rchande]

@jaredpar looks good. Thanks!