Update the required frameworks in the description #17942
Conversation
The description of this package is vague and incorrect. We now require .NET 4.6, not .NET 4.5, and that is only a build-time requirement, not a deploy requirement.
| @@ -5,8 +5,7 @@ | |||
| <description> | |||
| .Net Compilers package. Referencing this package will cause the project to be built using the specific version of the C# and Visual Basic compilers contained in the package, as opposed to any system installed version. | |||
|
|
|||
| Supported Platforms: | |||
| - .NET Framework 4.5 | |||
| This package can be used to compile code targeting any platform, but can only be run using the desktop .NET 4.6+ Full Framework. | |||
There was a problem hiding this comment.
"but requires .NET 4.6 to be installed on the developer or build machine"? "can only be run" seems an odd statement for a toolset.
There was a problem hiding this comment.
Suggestions? I waffled a bit on how to word this and didn't want to get too nitpicky.
|
@MattGertz this is a simple NuGet description update we're making after a customer was (understandably!) confused by our current description. We can put this in 15.1 so our next package there would get the update. Does this need a shiproom approval? |
|
@jasonmalinowski If it requires an insertion in d15rel, then it needs to go to Shiproom (and in that case, it definitely would not make the bar). If it is something we ship ourselves and don't inject into VS, then that would be different. |
|
@MattGertz No insertion required. We just upload these to nuget.org as a separate process. |
|
Not a problem then. |
|
test this please |
|
test vsi please |
The description of this package is vague and incorrect. We now require .NET 4.6, not
.NET 4.5, and that is only a build-time requirement, not a deploy requirement.
/cc @jasonmalinowski @jaredpar @dotnet/roslyn-infrastructure