Give an option to also implement IEquatable when generating Equals/GetHashCode. #18021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @dotnet/roslyn-ide |
CyrusNajmabadi
force-pushed
the
implementIEquatable
branch
from
ed85194 to
3fd0567
Compare
Pilchie
approved these changes
Mar 21, 2017
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.GenerateEqualsAndGetHashCodeFromMembers | |||
| { | |||
| using static GenerateEqualsAndGetHashCodeFromMembersCodeRefactoringProvider; | |||
There was a problem hiding this comment.
Using inside namespace - please just stahp!
| } | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateEqualsAndGetHashCode)] | ||
| public async Task TestImplementIEquatable1() |
There was a problem hiding this comment.
Better names for tests would be nice (mention that the interesting part is that it's a struct for example)
| } | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateEqualsAndGetHashCode)] | ||
| public async Task TestImplementIEquatable3() |
There was a problem hiding this comment.
What is this test trying to document?
There was a problem hiding this comment.
Good point on naming. Will fix up. To answer your question, in this specific case we are verifying that if you already implement IEquatable that we do not offer to implement that interface in the dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17650