Port Generate From Usage tests #18125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @dotnet/roslyn-ide for review |
|
retest windows_debug_vs-integration_prtest please |
rchande
approved these changes
Mar 28, 2017
| { | ||
| } | ||
|
|
||
| [Fact] |
| { | ||
| } | ||
|
|
||
| [Fact] |
dpoeschl
force-pushed
the
PortGFUTests
branch
2 times, most recently
from
42aebe9 to
4af24c5
Compare
Pilchie
previously requested changes
Mar 31, 2017
There was a problem hiding this comment.
I think this is fine as it is, but I think the most interesting things to test from the original are the ones that generate/affect other files. I wouldn't want to lose that coverage by removing the old ones.
(If this is just preliminary and more tests are coming then fine)
|
@Pilchie I added a "Generate class in new file" test. |
Pilchie
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original tests at https://github.com/dotnet/roslyn-internal/blob/master/Closed/Hosting/RoslynTaoActions/IntegrationTests/BasicGenerateFromUsage.xml / https://github.com/dotnet/roslyn-internal/blob/master/Closed/Hosting/RoslynTaoActions/IntegrationTests/CSharpGenerateFromUsage.xml