Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle forwarded types in PEModuleSymbol.GetWellKnownType. #18265

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Properly handle forwarded types in PEModuleSymbol.GetWellKnownType. #18265

merged 1 commit into from
Apr 4, 2017

Conversation

AlekseyTs
Copy link
Contributor

Fixes #18092.

@dotnet/roslyn-compiler Please review.

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review.

1 similar comment
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review.

@cston
Copy link
Member

cston commented Mar 30, 2017

LGTM

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, need a second sign-off.

3 similar comments
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, need a second sign-off.

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, need a second sign-off.

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, need a second sign-off.

jcouv
jcouv approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the background info.

@AlekseyTs AlekseyTs merged commit 8bcbd1c into dotnet:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
Area-Compilers Bug cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekseyTs @cston @jcouv @dnfclas