Add a test for keyword highlighting #18430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
approved these changes
Apr 4, 2017
added 2 commits
April 4, 2017 12:58
dpoeschl
reviewed
Apr 5, 2017
| { | ||
| } | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.Classification)] |
There was a problem hiding this comment.
Traits.Features.KeywordHighlighting?
| } | ||
| }"); | ||
|
|
||
| Verify("foreach", 3); |
There was a problem hiding this comment.
These tests are strange. I'd expect something with markup indicating which spans are highlighted and checking that.
|
|
||
| Verify("To", 3); | ||
| VisualStudio.ExecuteCommand("Edit.NextHighlightedReference"); | ||
| Assert.Equal(VisualStudio.Editor.GetCaretPosition(), 112); |
There was a problem hiding this comment.
Can you use SetUpEditor and then get the position from the $$ in that markup? I really dislike these large numbers that represent positions in code.
| Assert.Equal(VisualStudio.Editor.GetCaretPosition(), 112); | ||
| } | ||
|
|
||
| private void Verify(string marker, int expectedCount) |
| @@ -0,0 +1,254 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Uhh. This needs to be deleted.
| @@ -147,6 +142,9 @@ public bool IsSignatureHelpActive() | |||
| public string[] GetErrorTags() | |||
| => GetTags<IErrorTag>(); | |||
|
|
|||
| public int GetHighlightTagCount() | |||
| => GetTags<ITextMarkerTag>(tag => tag.Type == KeywordHighlightTag.TagId).Length; | |||
There was a problem hiding this comment.
Can we just return the tag spans themselves and check them?
added 2 commits
April 6, 2017 08:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag @dotnet/roslyn-ide for review