Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't offer 'use throw expression' when there is an explicit cast in source. It may change semantics. #18431

Merged
merged 2 commits into from
Apr 4, 2017
Merged

Don't offer 'use throw expression' when there is an explicit cast in source. It may change semantics. #18431

merged 2 commits into from
Apr 4, 2017

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi
Copy link
Member Author

Tagging @dotnet/roslyn-ide

@CyrusNajmabadi
Copy link
Member Author

retest windows_debug_unit32_prtest please

@CyrusNajmabadi CyrusNajmabadi merged commit 9292211 into dotnet:master Apr 4, 2017
@CyrusNajmabadi CyrusNajmabadi deleted the useThrowExplicitConversion branch April 4, 2017 20:35
@sharwell
Copy link
Member

sharwell commented Apr 4, 2017

📝 For anyone wondering, here's a publicly-accessible link to the issue:
https://developercommunity.visualstudio.com/content/problem/38798/ide0016-null-check-can-be-simplified-1.html

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Apr 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilchie Pilchie Pilchie approved these changes

Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @sharwell @Pilchie @dnfclas