Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes control type from NavBar's accessible names #18444

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

AmadeusW
Copy link
Contributor

@AmadeusW AmadeusW commented Apr 4, 2017

This fixes #18443 - Accessible name should not contain the type of the control.

Narrator automatically adds the control type, which means that with this fix in place, hitting Ctrl+F2 as described in #18443 will make Narrator say "Projects, WpfApp1, ComboBox"

Screenshot from AccEvent:
image

Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no idea the interface delegated the automation properties.

@Pilchie
Copy link
Member

Pilchie commented Apr 6, 2017

retest windows_debug_vs-integration_prtest please - https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_vs-integration_prtest/2257/ hit the failure that @CyrusNajmabadi fixed this morning I think.
retest windows_release_vs-integration_prtest please - https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_release_vs-integration_prtest/2224/ hit the failure that @CyrusNajmabadi fixed this morning I think.

@Pilchie
Copy link
Member

Pilchie commented Apr 6, 2017

retest windows_debug_vs-integration_prtest please

https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_vs-integration_prtest/2257/ hit the failure that @CyrusNajmabadi fixed this morning I think.

@Pilchie
Copy link
Member

Pilchie commented Apr 6, 2017

retest windows_release_vs-integration_prtest please

https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_release_vs-integration_prtest/2224/ hit the failure that @CyrusNajmabadi fixed this morning I think.

@Pilchie
Copy link
Member

Pilchie commented Apr 6, 2017

@dotnet/roslyn-infrastructure I can't seem to re-trigger these jobs. Any idea what's up?

@AmadeusW
Copy link
Contributor Author

AmadeusW commented Apr 7, 2017

retest windows_release_vs-integration_prtest please

@jasonmalinowski
Copy link
Member

@dotnet-bot retest windows_debug_vs-integration_prtest please

@jasonmalinowski
Copy link
Member

@Pilchie: I think we updated the regexes that you have to reference @dotnet-bot now.

@Pilchie
Copy link
Member

Pilchie commented Apr 13, 2017

Tagging @ManishJayaswal for approval, since we forgot to hit merge on this before :-/

@Pilchie Pilchie added this to the 15.3 milestone Apr 13, 2017
@ManishJayaswal
Copy link
Contributor

Approving without ask mode for accessibility fixes.

@Pilchie Pilchie merged commit 434e410 into dotnet:master Apr 14, 2017
@Pilchie
Copy link
Member

Pilchie commented Apr 14, 2017

Thanks @AmadeusW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Narrator says control type twice in the navigation bar
5 participants