-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes control type from NavBar's accessible names #18444
Removes control type from NavBar's accessible names #18444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had no idea the interface delegated the automation properties.
retest windows_debug_vs-integration_prtest please - https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_vs-integration_prtest/2257/ hit the failure that @CyrusNajmabadi fixed this morning I think. |
retest windows_debug_vs-integration_prtest please https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_vs-integration_prtest/2257/ hit the failure that @CyrusNajmabadi fixed this morning I think. |
retest windows_release_vs-integration_prtest please https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_release_vs-integration_prtest/2224/ hit the failure that @CyrusNajmabadi fixed this morning I think. |
@dotnet/roslyn-infrastructure I can't seem to re-trigger these jobs. Any idea what's up? |
retest windows_release_vs-integration_prtest please |
@dotnet-bot retest windows_debug_vs-integration_prtest please |
@Pilchie: I think we updated the regexes that you have to reference @dotnet-bot now. |
Tagging @ManishJayaswal for approval, since we forgot to hit merge on this before :-/ |
Approving without ask mode for accessibility fixes. |
Thanks @AmadeusW! |
This fixes #18443 - Accessible name should not contain the type of the control.
Narrator automatically adds the control type, which means that with this fix in place, hitting Ctrl+F2 as described in #18443 will make Narrator say "Projects, WpfApp1, ComboBox"
Screenshot from AccEvent: