Outlining VSI tests #18508
Merged
Outlining VSI tests #18508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpoeschl
approved these changes
Apr 6, 2017
| @@ -0,0 +1,89 @@ | |||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System; | |||
There was a problem hiding this comment.
I'm guessing these top usings are unused.
| Verify(spans, "Debug"); | ||
| } | ||
|
|
||
| private void Verify(IDictionary<string, ImmutableArray<TextSpan>> spans, string configuration) |
There was a problem hiding this comment.
VerifySpansInConfiguration or something? Just Verify makes the test method hard to read. It's probably fine since there's only one usage, but if someone added more tests that use it it'd get annoying.
| @@ -0,0 +1,46 @@ | |||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System; | |||
| @@ -259,6 +259,9 @@ public bool IsNavBarEnabled() | |||
| public TextSpan[] GetKeywordHighlightTags() | |||
| => Deserialize(_editorInProc.GetHighlightTags()); | |||
|
|
|||
| public TextSpan[] GetOutliningSpans() | |||
| => Deserialize(_editorInProc.GetOutliningSpans()); | |||
|
|
|||
| private TextSpan[] Deserialize(string[] v) | |||
jasonmalinowski
previously requested changes
Apr 7, 2017
| }|]"; | ||
| MarkupTestFile.GetSpans(input, out var text, out ImmutableArray<TextSpan> spans); | ||
| VisualStudio.Editor.SetText(text); | ||
| VisualStudio.Workspace.WaitForAsyncOperations(FeatureAttribute.Outlining); |
There was a problem hiding this comment.
No direct waits in tests; the wait should be moved to .GetOutliningSpans().
added 2 commits
April 7, 2017 13:26
rchande
force-pushed
the
outliningintegrationtest
branch
from
762068a to
eec4687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tag @dotnet/roslyn-ide for review