Don't show enum completion if text is typed after dot #18577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| static void Main(string[] args) | ||
| { | ||
| M(E.a$$) |
There was a problem hiding this comment.
probably good to have a comment saying that the normal symbolcompletionprovider gives us the values here, so we don't need to duplicate it. Also, we probably want a test in symbolcompletionprovidertests to make sure that we do get values from it.
| @@ -52,7 +52,9 @@ internal override bool IsInsertionTrigger(SourceText text, int characterPosition | |||
| return; | |||
| } | |||
|
|
|||
| var token = tree.FindTokenOnLeftOfPosition(position, cancellationToken); | |||
| var token = tree.FindTokenOnLeftOfPosition(position, cancellationToken) | |||
| .GetPreviousTokenIfTouchingWord(position); | |||
There was a problem hiding this comment.
is this a problem for VB as well?
CyrusNajmabadi
approved these changes
Apr 10, 2017
|
Thanks @CyrusNajmabadi , VB looks good and I added the comment/test you suggested. |
Pilchie
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18359
Tag @dotnet/roslyn-ide for review