Notify XAML of renames caused by Naming Rule fixes #18693
Conversation
dpoeschl
added
the
PR For Personal Review Only
dpoeschl
force-pushed
the
NamingStylesUpdateXAML
branch
from
a6d77ae to
7b2ecf1
Compare
dpoeschl
removed
the
PR For Personal Review Only
|
Tagging @dotnet/roslyn-ide for review. |
|
@rchande I added a unit test to prove the new Operation is applied only during application and not during preview, and that it receives the correct arguments. |
|
Thanks @dpoeschl! Looks good. |
|
retest ubuntu_14_debug_prtest please |
|
Tagging @MattGertz for Ask Mode consideration. The test failures are unrelated, but I'm working on getting them green. |
|
Approved -- as noted in side mail, you're also working on getting the tests fixed. |
|
retest windows_debug_vs-integration_prtest please |
|
retest windows_release_vs-integration_prtest please |
|
"xunit produced no error output but had exit code -2146233082" -- @dotnet/roslyn-infrastructure This happened on both of the failing runs. Is something generally wrong here? ExecutionEngineException... |
|
retest windows_debug_vs-integration_prtest please |
|
retest windows_release_vs-integration_prtest please |
|
retest windows_debug_vs-integration_prtest please https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_vs-integration_prtest/3606/ Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpWinForms.ChangeControlProperty [FAIL] Filed as #19191 |
|
retest windows_debug_vs-integration_prtest please |
Fixes #16562
Customer scenario: The customer renames a XAML type or element on the C# side to comply with a Naming Rule, and the name doesn't get updated on the XAML side.
Bugs this fixes: #16562
Workarounds, if any: The customer can manually update XAML references to the symbol.
Risk: Low. No other features depend on this aspect of Naming Rules, and we're already calling these VS APIs in other features. This change just makes those API calls available to Code Fixes.
Performance impact: Renaming an identifier via a Naming Rule fix will be slightly slower, but this brings it in line with the behavior of Inline Rename and Rename Tracking.
Is this a regression from a previous update?: No
Root cause analysis: This was a known missing aspect of the Naming Rules fixer that we didn't implement in RTM.
How did we miss it? This was a known missing aspect of the Naming Rules fixer that we didn't implement in RTM.
How was the bug found? Reported by a customer at https://developercommunity.visualstudio.com/content/problem/9702/naming-rule-violation-not-complete.html