Fix command handler ordering #18822
Fix command handler ordering #18822
Conversation
rchande
added
the
PR For Personal Review Only
|
retest this please |
rchande
removed
the
PR For Personal Review Only
|
Tag @dotnet/roslyn-ide for review. |
|
@rchande: please update the commit messages and PR description to describe what this change is or what bug it's fixing or whatever. 😄 |
|
Oops! Done @jasonmalinowski |
rchande
force-pushed
the
commandhandlerordering
branch
from
de07656 to
12f832b
Compare
There was a problem hiding this comment.
There are three references to #18065 in the repository code that need to be updated:
https://github.com/dotnet/roslyn/search?utf8=%E2%9C%93&q=18065&type=
If completion and brace completion are both active, shift-enter should commit both and complete the statement. This was not working because the completion command handler never called next handler for shift-enter and the line ender command handler was not ordered correctly. Fixes dotnet#18065
rchande
force-pushed
the
commandhandlerordering
branch
from
12f832b to
441e251
Compare
|
Ping @dotnet/roslyn-ide. Anyone else want to take a look? |
|
@jasonmalinowski Do you think this is still worth taking? |
|
We apologize, but we are closing this PR due to code drift. We regret letting this PR go so long without attention, but at this point the code base has changed too much for us to revisit older PRs. Going forward, we will manage PRs better under an SLA currently under draft in issue #26266 – we encourage you to add comments to that draft as you see fit. Although that SLA is still in draft form, we nevertheless want to move forward with the identification of older PRs to give contributors as much early notice as possible to review and update them. If you are interested in pursuing this PR, please reset it against the head of master and we will reopen it. Thank you! |
jaredpar
added
the
Resolution-Expired
Customer scenario
With automatic brace completion and intellisense active, customer types shift+enter to commit intellisense, complete the pending brace completion, and complete the statement. Completion is committed, but brace completion is not.
Bugs this fixes:
#18065
Workarounds, if any
Customer has to manually finish their braces because this keyboard shortcut does not work.
Risk
Moderately risky. It is possible that this change will introduce an unanticipated change in the interaction between completion and brace completion.
Performance impact
Low. We will do extra work to commit brace completion if the user uses the command.
Is this a regression from a previous update?
No, we shipped Dev14 like this.
Root cause analysis:
There were integration tests covering this scenario but they had the wrong baselines or were skipped.
How was the bug found?
We noticed this while porting integration tests to the new framework.