Fix analysis of IOperation descendants for BoundDelegateCreationExpre… #19307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion The current IOperation API implementation of BoundDelegateCreationExpression has a bunch of issues and needs to be redesigned. This is tracked by dotnet#8897 and will be addressed post 15.3. Meanwhile, to unblock analyzers on code containing delegate creation expressions with lambda arguments, this bound node has been switched to OperationKind.None with override for Children property. Fixes the first repro case provided in dotnet#8884
|
Tagging @AlekseyTs @cston @dotnet/analyzer-ioperation for review |
|
LGTM |
…ng test to account for the change
AlekseyTs
reviewed
May 9, 2017
|
|
||
| public void Method(Delegate d) | ||
| { | ||
| var a = /*<bind>*/new Delegate(Method2)/*</bind>*/; |
There was a problem hiding this comment.
Method2 [](start = 39, length = 7)
Please add a test with an explicit receiver (a parameter reference, for example). We should get it in the output. #Pending
|
Tagging @MattGertz for ask mode approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssion
Customer scenario
Customer uses IOperation analyzers in their code base and see large number of false positives in code with delegate creation expressions taking lambda arguments. For example see #8884 (comment)
Bugs this fixes:
Fixes #8884 (comment)
Workarounds, if any
Customer has to suppress all IOperation analyzers in code containing delegate creation expressions OR disable these analyzers completely.
Risk
Low. We have taken same approach for bunch of other bound nodes that still require IOperation design.
Performance impact
Low.
Is this a regression from a previous update?
No.
Root cause analysis:
The current IOperation API implementation of BoundDelegateCreationExpression has a bunch of issues and needs to be redesigned. This is tracked by #8897 and will be addressed post 15.3. Meanwhile, to unblock analyzers on code containing delegate creation expressions with lambda arguments, this bound node has been switched to OperationKind.None with override for Children property.
How was the bug found?
Dogfooding/customer reports.