Fix building on 15.3 #19331
Merged
Fix building on 15.3 #19331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basoundr
reviewed
May 8, 2017
| @@ -10,6 +10,7 @@ | |||
| <AssemblyName>Microsoft.CodeAnalysis.VisualBasic.CodeStyle</AssemblyName> | |||
| <TargetFramework>netstandard1.3</TargetFramework> | |||
| <PackageTargetFallback>portable-net45+win8;dotnet</PackageTargetFallback> | |||
| <NoWarn>$(NoWarn);40057</NoWarn> | |||
|
LGTM as far as the nowarn change goes |
|
merging as these contain no changes to code behavior |
|
Changes to the compiler code base require explicit compiler sign off. This change does not have this. Also where is the ask mode approval for this bug? |
This is due to a bug in the SDK. They are unconditionally disabling option strict in the VB targets file that is included with the current 15.3 builds. The proper fix is not to make a code change. It is to re-enable Option Strict in the props files to work around the issue. Please open a bug to undo this change and put the proper fix into the code base. |
This was referenced May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dogfooding 15.3 I ran into a lot of instances of BC40057 being offered due to default namespace imports of assemblies that don't exist (introduced [here](this dotnet/sdk#1127)). These seem safe to ignore.
BasicCodeAnalysis.vbprojhas a few new implicit conversion warning under 15.3 due to overload resolution on Interlocked.CompareExchange which I have fixed but I would like @dotnet/roslyn-compiler to review these changes.BasicScriptingTest.vbprojalso has implicit conversion errors that needed to be fixed up. I am not too concerned about these fixes in the test project but would like @dotnet/roslyn-interactive to take a look all the same.