Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not even attempt to create indices for non-C#/VB projects. #19357

Merged
merged 1 commit into from
May 9, 2017

Conversation

CyrusNajmabadi
Copy link
Member

Tagging @jasonmalinowski @dotnet/roslyn-infrastructure

Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have tests, but we should not block merging this waiting on that.

@jasonmalinowski
Copy link
Member

Also tagging @dotnet/roslyn-ide for any additional reviews.

@MattGertz we've identified a crash in TypeScript projects that would block tomorrow's RI. At this point we believe that might be the only pending issue, so we'll be looking to get this merged in.

@CyrusNajmabadi
Copy link
Member Author

Have smoke tested this.

Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Let's get this merged.

@CyrusNajmabadi
Copy link
Member Author

Will try to merge myself. If i'm not around, anyone is free to merge this in.

@CyrusNajmabadi
Copy link
Member Author

retest windows_debug_vs-integration_prtest please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants