-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not even attempt to create indices for non-C#/VB projects. #19357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have tests, but we should not block merging this waiting on that.
Also tagging @dotnet/roslyn-ide for any additional reviews. @MattGertz we've identified a crash in TypeScript projects that would block tomorrow's RI. At this point we believe that might be the only pending issue, so we'll be looking to get this merged in. |
Have smoke tested this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Let's get this merged.
Will try to merge myself. If i'm not around, anyone is free to merge this in. |
retest windows_debug_vs-integration_prtest please |
Tagging @jasonmalinowski @dotnet/roslyn-infrastructure