Migrate BasicEditAndContinue integration tests from Tao to .NET #19381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarolf
reviewed
May 10, 2017
|
|
||
| public void ExecuteStatement(string statement) => _debugger.ExecuteStatement(statement); | ||
|
|
||
| public void CheckExpression(string expression, string expectedType, string expectedValue) |
There was a problem hiding this comment.
CheckExpression [](start = 20, length = 15)
Why is this needed? can't this just be an assert in the test?
There was a problem hiding this comment.
Thank you! Agree. Moved asserts from InProc to OutProc.
jmarolf
approved these changes
May 10, 2017
This was referenced May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (almost) #16689 (also will need to remove BasicEditAndContinue.xml at another repository).
Tests only. No need for ask mode approval.
Tagging @dotnet/roslyn-ide for review