Be resilient to documents/projects with null-filepaths in our persistence layer. #19446
Conversation
|
Tagging @dotnet/roslyn-ide |
|
Customer scenario TypeScript crashes. Bugs this fixes: Reported directly from TypeScript. Workarounds, if any None. Risk Low. Performance impact Low. Is this a regression from a previous update? Yes. Root cause analysis: Our switch to sqlite introduced a crash for TypeScript. This is because our persistence layer assumed that all docuemnts/project would have associated non-null filepaths with them. In some scenarios TypeScript does not supply these values. Because we've never required that these values be non-null, we need to be resilient to that sort of data flowing through to the persistence layer. How was the bug found? Direct report from TypeScript. |
|
Tagging @MattGertz |
| } | ||
|
|
||
| return solution; | ||
| } | ||
|
|
||
| private IPersistentStorage GetStorage(Solution solution) | ||
| protected IPersistentStorage GetStorage(Solution solution) |
There was a problem hiding this comment.
So we can use it from SQLitePersistentStorageTests.cs
No description provided.