Fix case that was causing us to not offer completion after a case-pattern-label in a switch. #19531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tern-label in a switch.
|
retest windows_build_correctness_prtest please |
CyrusNajmabadi
changed the title
|
Tagging @MattGertz Customer scenario user cannot use completion after a "pattern case label" (added when we added pattern matching). Bugs this fixes: Fixes #15348 Workarounds, if any none. Risk Low. Performance impact low. Is this a regression from a previous update? no. Root cause analysis: It was not missed. We found it when we tested pattern matching. But the bug has never been fixed. it's driving me crazy, so i'm just fixing it :) How was the bug found? Found during pattern matching test pass. |
|
This was also code reviewed in #19494 |
Pilchie
approved these changes
May 16, 2017
| </Document>) | ||
|
|
||
| state.SendTypeChars("this") | ||
| Await state.AssertSelectedCompletionItem(displayText:="this", isHardSelected:=True) |
There was a problem hiding this comment.
I'd love to see a test at the keyword recommender and symbol provider as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15348