Fix perf regression in gotodef. #19539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @MattGertz Customer scenario Perf of goto-def added several dozen ms in one of our RPS tests. Bugs this fixes: Workarounds, if any None. Risk Low. Performance impact Perf is improved. Is this a regression from a previous update? Yes. Root cause analysis: Work to make our system better handle OOP (by computing more information up front), ended up hurting a non-OOP scenario. How was the bug found? RPS test. |
rchande
approved these changes
May 16, 2017
|
retest windows_debug_vs-integration_prtest please |
|
retest windows_release_vs-integration_prtest please |
|
@CyrusNajmabadi Loving the comments in the code. |
|
retest this please |
|
retest windows_release_vs-integration_prtest please |
1 similar comment
|
retest windows_release_vs-integration_prtest please |
|
retest windows_debug_vs-integration_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_workitems?id=433771&projectId=0bdbc590-a062-4c3f-b0f6-9383f67865ee&src=WorkItemMention&src-action=artifact_link&fullScreen=true&_a=edit