Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back 'beta2' nuget moniker for official builds. #19546

Merged
merged 1 commit into from
May 16, 2017

Conversation

shyamnamboodiripad
Copy link
Contributor

Add back the 'beta2' nuget package moniker for official builds.

The moniker was accidentally removed in a2e2bf4 (PR #19469).

@shyamnamboodiripad
Copy link
Contributor Author

@tmeschter @jasonmalinowski @dotnet/roslyn-infrastructure

@jasonmalinowski: I am assuming explicit ask mode approval is not required for this change since this is infrastructure - but let me know if that's not a valid assumption.

@jasonmalinowski
Copy link
Member

This does impact shipping bits (we stamp this in binaries today) so we should go through ask mode process.

@shyamnamboodiripad
Copy link
Contributor Author

Tagging @MattGertz for ask mode approval

Customer scenario

An earlier commit accidentally merged some code that caused the version moniker for all Roslyn nuget packages to change from 'beta2' to 'dev'. For example, the package versions went from 2.3.0-beta2-61715-06 to 2.3.0-dev-61715-06. This change fixes the moniker back to 'beta2'. Customers depend on the names of our nuget packages and shipping with opaque version moniker 'dev' would make it hard for users to figure out what release the package really maps to.

Bugs this fixes:

Workarounds, if any
None

Risk
Low

Performance impact
None

Is this a regression from a previous update?
Yes

Root cause analysis:
This was the result of a bad merge.

How was the bug found?
We noticed today that packages being published to the Roslyn myget feed had the wrong moniker.

@shyamnamboodiripad
Copy link
Contributor Author

@dotnet-bot test this please

tmeschter added a commit to tmeschter/roslyn that referenced this pull request May 16, 2017
* Update `RoslynAssemblyVersionBase` from 2.3.0 to 2.6.0
* Update `RoslynFileVerionBase` from 2.3.0 to 2.6.0
* Reset `RoslynNuGetMoniker` to beta1

Also incorporate @shyamnamboodiripad's fix in dotnet#19546.
@jcouv
Copy link
Member

jcouv commented May 16, 2017

@dotnet-bot test windows_debug_vs-integration_prtest please

@jasonmalinowski jasonmalinowski merged commit 717be53 into dotnet:master May 16, 2017
@shyamnamboodiripad shyamnamboodiripad deleted the FixNugetMoniker branch May 16, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants