Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Interface Impementation: Verify resulting assembly and runtime behavior when targeting CoreCLR. #20097

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Default Interface Impementation: Verify resulting assembly and runtime behavior when targeting CoreCLR. #20097

merged 1 commit into from
Jun 9, 2017

Conversation

AlekseyTs
Copy link
Contributor

@dotnet/roslyn-compiler Please review a test only change.

@AlekseyTs AlekseyTs added Area-Compilers Language-C# Feature - Default Interface Impl Default Interface Implementation Test Test failures in roslyn-CI labels Jun 8, 2017
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review a test only change.

1 similar comment
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review a test only change.

@jcouv
Copy link
Member

jcouv commented Jun 8, 2017 

static void Main()

Not blocking this PR, but can Main be in an interface now?

Refers to: src/Compilers/CSharp/Test/Symbol/Symbols/DefaultInterfaceImplementationTests.cs:161 in 332c4ab. [](commit_id = 332c4ab, deletion_comment = False)

jcouv
jcouv approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice!

@AlekseyTs
Copy link
Contributor Author

can Main be in an interface now?

I believe LDM decided that it should be legal. You still need a class or a struct, though, in order to have an instance of an interface.

@AlekseyTs AlekseyTs merged commit 045940d into dotnet:features/DefaultInterfaceImplementation Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
Area-Compilers cla-already-signed Feature - Default Interface Impl Default Interface Implementation Language-C# Test Test failures in roslyn-CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @jcouv @dnfclas