Fix completion in AdhocWorkspace #20108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctMemberInsertingCompletionProvider I noticed this while working through an issue using the CompletionService in OmniSharp. `GetOpenDocumentInCurrentContextWithChanges(...)` allows the caller to retrieve a Document from a SourceText. It achieves this be calling `Workspace.TryGetWorkspace(...)` with the SourceText's SourceTextContainer. However, in the case of a standard SourceText, this is just a StaticContainer that changes every time `SourceText.WithChanges(...)` is called. So, if the SourceText is updated for a particular Document in an AdhocWorkspace, calling `GetOpenDocumentInCurrentContextWithChanges(...)` for the new SourceText will fail because its container is different than the one that was initially registered with the Workspace.
CyrusNajmabadi
approved these changes
Jun 8, 2017
rchande
approved these changes
Jun 8, 2017
Pilchie
approved these changes
Jun 8, 2017
jasonmalinowski
approved these changes
Jun 8, 2017
|
|
||
| //var sourceText = textSnapshot.AsText(); |
There was a problem hiding this comment.
This was probably a good hint that this code was suspect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working through an issue using the CompletionService in OmniSharp. Essentially, the
AbstractMemberInsertingCompletionProviderwas never updated to stop callingGetOpenDocumentInCurrentContextWithChanges(...)as it did in the era before theCompletionServicewhen every provider was passed anITextViewandITextBuffer. Nowadays, since there's a readily available Document, it can just use that.Without this change, it breaks a scenario with AdhocWorkspace and other simple Workspace implementations. Essentially,
GetOpenDocumentInCurrentContextWithChanges(...)allows the caller to retrieve a Document from a SourceText. It achieves this be callingWorkspace.TryGetWorkspace(...)with the SourceText's SourceTextContainer. However, in the case of a standard SourceText, this is a StaticContainer that changes every timeSourceText.WithChanges(...)is called. So, if the SourceText is updated for a particular Document in an AdhocWorkspace, callingGetOpenDocumentInCurrentContextWithChanges(...)on the new SourceText will fail because its container is different than the one that was initially registered with the Workspace.cc @dotnet/roslyn-ide