-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored IAssignment/ICompoundAssignment as we discussed and removed IndexPropertyReference #20431
Merged
Merged
refactored IAssignment/ICompoundAssignment as we discussed and removed IndexPropertyReference #20431
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8753f9c
added IBaseAssignmentExpression and made IComponentAssigntExpression …
heejaechang 6054e7b
added IBaseCompoundAssignmentExpression
heejaechang acb3bdf
added IBasePropertyReferenceExpression
heejaechang 56cc92f
fix some missing issues
heejaechang 38dfa2e
new public interfaces
heejaechang e9b08af
removed public apis
heejaechang a859163
changed IInrementExpression. no longer derived from ICompoundAssignme…
heejaechang 7dada16
addressed AssignmentExpression design
heejaechang ba0c404
remove IndexedPropertyReference and merge it to PropertyReference
heejaechang 9597485
made CaseClause to follow same pattern
heejaechang ece36be
made symbol initializer to follow same pattern
heejaechang 2e2bde4
fixed wrong pattern
heejaechang d3a5cff
more fix for consistancy
heejaechang 03f3a68
made all tests pass
heejaechang 5f680d6
addressed PR feedback
heejaechang c2fcba9
missed adding simple to one comment
heejaechang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
removed public apis
- Loading branch information
commit e9b08af56e684f9752fb731698fcfdb9d160f69d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did IOperations APIs previously ship?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me take a look. we did ship it under feature flag though